Examples/refactor custom plugin examples #1946
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Base automatically changed from
fix/examples_custom_operator_downloads
to
master
November 29, 2024 12:36
90dae29 to
3d46569
Compare
PProfizi
commented
Nov 29, 2024
examples/08-python-operators/02-python_operators_with_dependencies.py
Outdated
Show resolved
Hide resolved
PProfizi
commented
Nov 29, 2024
ansjhajjar
approved these changes
Nov 29, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1946 +/- ##
==========================================
+ Coverage 88.03% 88.06% +0.02%
==========================================
Files 83 83
Lines 9973 9993 +20
==========================================
+ Hits 8780 8800 +20
Misses 1193 1193 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor examples on custom Python operators and plugins by creating helpers to download files.
This prepares their revamping into tutorials and hides the file retrieval logic from the user, which is something we do not need to show for the examples.