+
Skip to content

fix(animation): add mode number and frequency value with unit in mode animations #1700

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
Jun 5, 2025
Merged

fix(animation): add mode number and frequency value with unit in mode animations #1700

merged 10 commits into from
Jun 5, 2025

Conversation

MeenaBytes
Copy link
Contributor

@MeenaBytes MeenaBytes commented Aug 14, 2024 •
edited
Loading

This fixes:

  • Issue with animator text showing mode number instead of frequency value.
  • Missing unit in frequency value
  • Add a check if supplied mode number exists in field container.

Fixes #1699

MeenaBytes and others added 5 commits August 14, 2024 01:35
@MeenaBytes
Fixes the mesh deformation for mode shape animation
98fde68 
This commit make deform_by default for mode animation.
@MeenaBytes
pass deformation scaling factor to animator
7faf784 
This fix transfers deformation scale factor to animator
@MeenaBytes
making use of scale factor per frame
27d47aa 
This fix adds use of scale factor per frame
@MeenaBytes
Handling integer type scale factor
6b31ec6 
This change handles integer type scale factor in animator.
ideally integer type scale factor should be acceptable by scale operator.
add mode number and mode frequency in plotter text
4594606
@MeenaBytes MeenaBytes marked this pull request as ready for review August 14, 2024 19:54
@codecov Codecov
Copy link

codecov bot commented Aug 14, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 87.50000% with 1 line in your changes missing coverage. Please review.

Project coverage is 84.02%. Comparing base (598f64a) to head (7d4d780).
Report is 1 commits behind head on master.

✅ All tests successful. No failed tests found.

Additional details and impacted files 
@@           Coverage Diff           @@
##           master    #1700   +/-   ##
=======================================
  Coverage   84.02%   84.02%           
=======================================
  Files          91       91           
  Lines       10515    10522    +7     
=======================================
+ Hits         8835     8841    +6     
- Misses       1680     1681    +1

@PProfizi PProfizi self-requested a review September 18, 2024 14:17
@PProfizi PProfizi changed the title Adds mode number and frequency value with unit in animator feat(animation): add mode number and frequency value with unit in mode animations Jun 5, 2025
@PProfizi PProfizi added the bug Something isn't working label Jun 5, 2025
@PProfizi PProfizi changed the title feat(animation): add mode number and frequency value with unit in mode animations fix(animation): add mode number and frequency value with unit in mode animations Jun 5, 2025
@PProfizi PProfizi merged commit f90f640 into master Jun 5, 2025
79 of 81 checks passed
@PProfizi PProfizi deleted the fix_mode_frequency_value_1699 branch June 5, 2025 18:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@PProfizi PProfizi PProfizi approved these changes

Assignees

No one assigned

Labels

bug Something isn't working

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

animation.animate_mode() lists the mode number as the frequency

2 participants

@MeenaBytes @PProfizi
点击 这是indexloc提供的php浏览器服务，不要输入任何密码和下载