MeshedRegion.plot() with PropertyField #1526
Conversation
|
Hi @AlejandroFernandezLuces, could you please take a look at this PR? |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1526 +/- ##
==========================================
+ Coverage 84.16% 84.20% +0.03%
==========================================
Files 82 82
Lines 9655 9672 +17
==========================================
+ Hits 8126 8144 +18
+ Misses 1529 1528 -1 |
There was a problem hiding this comment.
Yes, I think activating categories flag and using the scalars_bar is the best way to represent what you want.
A side comment, why are you filling a kwargs map instead of using the arguments in the function calls? I personally find it clearer to use the parameters directly.
src/ansys/dpf/core/plotter.py
Outdated
| kwargs = self._set_scalar_bar_title(kwargs) | ||
| kwargs["scalar_bar_args"]["n_labels"] = len(set(field.data)) | ||
| kwargs["scalar_bar_args"]["fmt"] = "%.0f" |
There was a problem hiding this comment.
I would prefer to directly use the add_scalar_bar directly, I think something like this should work in this context
| kwargs = self._set_scalar_bar_title(kwargs) | |
| kwargs["scalar_bar_args"]["n_labels"] = len(set(field.data)) | |
| kwargs["scalar_bar_args"]["fmt"] = "%.0f" | |
| self._plotter.add_scalar_bar( | |
| title='Your title', | |
| n_labels=len(set(field.data)) | |
| fmt='%.0f', | |
| ) |
There was a problem hiding this comment.
@AlejandroFernandezLuces I think the original idea of using kwargs is to use setdefault so that if the argument is given as a kwarg to the plot function by the user then it is not overriden by what we put here. I'll improve the code to do that correctly.
|
Thanks @AlejandroFernandezLuces! |
Not sure what is happening there, you can try to set |
|
I managed to get this look with the latest commit |
|
NB: the default cmap used is |
Signed-off-by: paul.profizi <paul.profizi@ansys.com>
Signed-off-by: paul.profizi <paul.profizi@ansys.com>
Signed-off-by: paul.profizi <paul.profizi@ansys.com>
Signed-off-by: paul.profizi <paul.profizi@ansys.com>
Signed-off-by: paul.profizi <paul.profizi@ansys.com>
Signed-off-by: paul.profizi <paul.profizi@ansys.com>
3ef8f12 to
c8eb2b3
Compare
| os.environ["PYVISTA_OFF_SCREEN"] = "true" | ||
| core.settings.bypass_pv_opengl_osmesa_crash() | ||
| os.environ["MPLBACKEND"] = "Agg" | ||
| # core.settings.disable_off_screen_rendering() |
There was a problem hiding this comment.
This needs to be reverted before merging, right?
| show_axes=kwargs.pop("show_axes", True), | ||
| **kwargs, | ||
| ) | ||
| if isinstance(field_or_fields_container, PropertyField): |
There was a problem hiding this comment.
| if isinstance(field_or_fields_container, PropertyField): | |
| elif isinstance(field_or_fields_container, PropertyField): |
|
Hello @PProfizi! If this issue needs to remain open, please comment below with If you want this repository to be excluded from this automated maintenance process, please let us know by filling in the opt-out request form. |
Add the possibility to plot a
PropertyFieldon aMeshedRegion.Will have to add
PropertyField.plot(mesh)with mandatory mesh as aPropertyFieldcurrently most likely does not have a mesh asosciated.The PyVista options for the scalar bar still need a little bit of tweaking. Some colors are even missing from the scalar bar:
