Fix tokens for extraSmallContainerSize() in IconButtonDefaults #781
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
|
it looks like we made the same mistake across the other *ContainerSize functions (smallContainerSize, mediumContainerSize, largeContainerSize, extraLargeContainerSize. Could you fix those too? |
Before: XSmallIconButtonTokens.DefaultLeadingSpace + XSmallIconButtonTokens.DefaultLeadingSpace After: XSmallIconButtonTokens.DefaultLeadingSpace + XSmallIconButtonTokens.DefaultTrailingSpace
Thanks for pointing this out. Added those in the latest amended commit: 8fdc916 . |
Proposed Changes
XSmallIconButtonTokens.DefaultLeadingSpacetoXSmallIconButtonTokens.DefaultTrailingSpace. For now they're the same value, which follows Material Design 3 Expressive, so no bugs for now, even if this isn't fixed. This is just for logical correctness, and future safety.Testing
Test: It's a simple fix, so it's easy to test: just make sure no typo out there.