Close leaked InputStream #737
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
framework icon also has this problem. |
liutikas
approved these changes
Jun 26, 2025
|
This fails to compile please fix. |
harrytmthy
reviewed
Jul 4, 2025
| return new BitmapDrawable(context.getResources(), | ||
| BitmapFactory.decodeStream(is)); | ||
| } catch (Exception e) { | ||
| /* ignore */ |
There was a problem hiding this comment.
Nit: for consistency with the existing error logging in loadDrawableInner() (e.g. line 590), consider logging the exception instead of silently ignoring it:
catch (Exception e) {
Log.e(TAG, "Unable to load image from URI: " + getUri(), e);
}This would make debugging easier while preserving current fallback behavior.
liutikas
reviewed
Jul 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Testing
Test: no test.
Issues Fixed
Fixes: The bug on https://issuetracker.google.com/issues/387245369 being fixed