Send mail with %Mail.Message{} and Multiple recipients for email #5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 6 commits
July 4, 2019 13:02
This function accepts a %Mail.Message{} as an argument,
the data is used to send message to all recipients
as described in the map.
The :mail package is used to build the email message.
The current implementation handles error messages by not completing the SMTP transaction. At any point, if the response from the server is an error, the SMTP session is closed.
This is based on RFC5321 4.5.2
|
@andrewtimberlake Hi, can you review this PR when you some time. |
5f46609 to
7b602a7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements the
Mailroom.SMTP.sendfunction that can take a%Mail.Message{}as an argument. The map is used to send all the required commands to the Mail Submission Agent.The responses from the MSA are verfied to make sure that there are no errors. When an error response is caught, the session is closed and the EMail is not successfully sent. The
sendfunction exits with an error tuple.When Email is sent successfully,
sendexits with a:ok.The same error handling is made for
send_messagefunction too.PS. I have also implemented the escaping of the a period(
.) at start of line according to rfc5321 4.5.2. I can make a seperate PR for this if that is necessary. This can be found in ce90849.