+
Skip to content

fix(platform): add Nx deps as peerDependencies #1117

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 27, 2024
Merged

Conversation

brandonroberts
Copy link
Member

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Other... Please describe:

Which package are you modifying?

  • vite-plugin-angular
  • vite-plugin-nitro
  • vitest-angular
  • astro-angular
  • create-analog
  • router
  • platform
  • content
  • nx-plugin
  • trpc

What is the current behavior?

Closes #

What is the new behavior?

  • Nx dependencies are added to @analogjs/platform as peer dependencies which are installed by all major package managers
  • Removed explicit Nx dependencies from template apps
  • Removed explicit installation of Nx from docs instructions

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

[optional] What gif best describes this PR or how it makes you feel?

Copy link

netlify bot commented May 27, 2024

Deploy Preview for analog-docs ready!

Name Link
🔨 Latest commit e205a9c
🔍 Latest deploy log https://app.netlify.com/sites/analog-docs/deploys/66540b5dc9368400087c7777
😎 Deploy Preview https://deploy-preview-1117--analog-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented May 27, 2024

Deploy Preview for analog-blog ready!

Name Link
🔨 Latest commit e205a9c
🔍 Latest deploy log https://app.netlify.com/sites/analog-blog/deploys/66540b5dc6b52a00081352b7
😎 Deploy Preview https://deploy-preview-1117--analog-blog.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented May 27, 2024

Deploy Preview for analog-app ready!

Name Link
🔨 Latest commit e205a9c
🔍 Latest deploy log https://app.netlify.com/sites/analog-app/deploys/66540b5da04d900008316744
😎 Deploy Preview https://deploy-preview-1117--analog-app.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented May 27, 2024

Deploy Preview for analog-ng-app ready!

Name Link
🔨 Latest commit e205a9c
🔍 Latest deploy log https://app.netlify.com/sites/analog-ng-app/deploys/66540b5d3d7bc9000811113e
😎 Deploy Preview https://deploy-preview-1117--analog-ng-app.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@brandonroberts brandonroberts merged commit b255370 into beta May 27, 2024
@brandonroberts brandonroberts deleted the fix-nx-peer-deps branch May 27, 2024 04:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant
点击 这是indexloc提供的php浏览器服务,不要输入任何密码和下载