fix: assume that a vulnerability with no ranges is always vulnerable #2759
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alex Goodman <wagoodman@users.noreply.github.com>
kzantow
approved these changes
Jun 30, 2025
westonsteimel
approved these changes
Jul 1, 2025
|
bypassing quality gate -- it is not expected to pass since fixing this bug necessarily means adding FPs to known results. @westonsteimel and I have verified the results are what we'd expect. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Today it is possible to have NVD entries that have no range information for a CVE, such as with CVE-2010-4756, however, the correct interpretation of this is that all versions are vulnerable. This looks like it was introduced in the v6 development effort (based on the data shape changes I'm seeing, this class of bugs makes sense) and it led to a reduction in FPs with the exception for one finding (which is why it was merged).