fix: DB should hydrate for when the client has new features #2758
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alex Goodman <wagoodman@users.noreply.github.com>
kzantow
approved these changes
Jun 30, 2025
willmurphyscode
approved these changes
Jun 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Grype client should hydrate the DB when there are new client features.
For example: if a v6.0.2 client downloads a v6.0.2 DB and hydrates it, then a newer client (v6.0.3) runs a scan then the client should hydrate the DB (assuming there is no v6.0.3 DB available to download for whatever reason).
New clients may depend on new columns existing in the DB, and hydrating will auto-migrate the tables to include these new columns (with empty values). This doesn't mean that the client will logically perform the correct behavior if the new feature does not gracefully degrade, but it does prevent against SQL-level errors about columns not existing. Note that this would still allow for older clients to use the DB hydrated by the new client.