tls: replace rustls-pemfile usage with rustls-pki-types #1122
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rusts-pemfile has been archived and won't see future updates. The rustls-pki-types crate has supported PEM parsing since 1.9.0. This commit converts the existing parsing while maintaining semver compatibility, with the exception of the Error::Pem() enum variant, that exposed a rustls-pemfile type. This breaking change is **not** considered in-scope for ureq's semver policy based on the pre-existing rustdoc comment.
|
@cpu Excellent! Thank you for straightening this out. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rusts-pemfile has been archived and won't see future updates. The rustls-pki-types crate has supported PEM parsing since v1.9.0.
This commit converts the existing parsing while maintaining semver compatibility, with the exception of the
Error::Pem()enum variant. This variant previously exposed arustls-pemfileerror type, and now switches to a similarrustls-pki-typeserror type. This breaking change is not considered in-scope forureq's semver policy based on the pre-existing rustdoc comment:Resolves #1120