error:Translate Error::Timeout into io::ErrorKind::Timedout #1124
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This enables better categorization of errors. In particular, TcpTransport translates `ErrorKind` to `ureq::Error::Timeout` errors on timeout conditions. These should then be re-raised as `ErrorKind::Timedout` errors behind the `io::Error` abstraction. Omitting this error-structure forces downstream error-handlers to resort to string-matching to distinguish timeout-errors from other errors.
|
Not sure this is necessarily the best way to solve it. But in particular, I've discovered some (but not all) errors disguising themselves as |
|
@rawler thanks for submitting this. I've been thinking back/forth on whether we can land it. In some respects it can be considered a breaking change. |
|
Good reflection. I briefly touched on that thought too, but my thinking is that anyone relying on the old behavior would (hopefully) not be matching on |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This enables better categorization of errors.
In particular, TcpTransport translates
ErrorKindtoureq::Error::Timeouterrors on timeout conditions. These should then be re-raised asErrorKind::Timedouterrors behind theio::Errorabstraction.Omitting this error-structure forces downstream error-handlers to resort to string-matching to distinguish timeout-errors from other errors.