+
Skip to content

feat(messaging): support for frameId #88

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Jan 10, 2025
Merged

feat(messaging): support for frameId #88

merged 7 commits into from
Jan 10, 2025

Conversation

Mehdi-Hp
Copy link
Contributor

@Mehdi-Hp Mehdi-Hp commented Jan 8, 2025

Adding support for optional frameId in Browser.tabs.sendMessage

aklinker1
aklinker1 requested changes Jan 9, 2025
View reviewed changes
Copy link
Owner

@aklinker1 aklinker1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR and updating the tests.

One small change, I prefer to avoid runtime type-checks if typescript already reports as fine. The error the browser throws in those cases is good enough.

@aklinker1 aklinker1 changed the title feat(messaging): support for frameId feat(messaging): support for frameId Jan 9, 2025
@aklinker1
Copy link
Owner

aklinker1 commented Jan 9, 2025 •
edited
Loading

Looks like there are some type errors in src/extension.test-d.ts causing checks to fail

@Mehdi-Hp
Copy link
Contributor Author

Looks like there are some type errors in src/extension.test-d.ts causing checks to fail

Fixed.
Updated the docs too, but I think that needs your edit.

@aklinker1 aklinker1 merged commit 63f961c into aklinker1:main Jan 10, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@aklinker1 aklinker1 aklinker1 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Mehdi-Hp @aklinker1
点击 这是indexloc提供的php浏览器服务，不要输入任何密码和下载