fix(fake-browser): ensure nested objects are not mutated on set operation #84
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bas950
reviewed
Dec 11, 2024
Co-authored-by: Bas van Zanten <bas.van.zanten007@gmail.com>
aklinker1
approved these changes
Dec 11, 2024
I am not quite sure, I've so far only really used the storage of fake browser |
|
Now that I know messaging is weird for recursive objects, should probably implement that behavior as well. Not in this PR though, I'll do it separately |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a nasty bug that I came across when writing storage tests inside of wxt and I couldn't figure out why at the time and now my friend @Bas950 came across the same issue and it turns out that the
fakebrowserpackage doesn't remove the references when updating the object.I tried using
structuredClonebut it didn't quite fix the issue in some deeply nested objects / arrays.Idk if you remember this @aklinker1 https://discord.com/channels/1212416027611365476/1224505556346212515/1308235414582071358 but this is the fix of that issue.
The bun lock probably got updated because I have the latest version of it.
This pull request includes changes to the
fake-browserpackage to improve the handling of nested objects in the storage API. The most important changes include adding a new test case to ensure nested objects are not mutated and modifying thesetmethod to deep clone the items before setting them.Improvements to storage API:
packages/fake-browser/src/apis/storage.test.ts: Added a test case to ensure that setting a nested object does not mutate the original object.Codebase modification:
packages/fake-browser/src/apis/storage.ts: Modified thesetmethod indefineStorageAreato deep clone the items usingJSON.parse(JSON.stringify(items))before setting them.