refactor translate-value-case and translate-composite #75
Conversation
db69136 to
6b5cb5d
Compare
|
Hmm, for some reason |
6b5cb5d to
1f75f09
Compare
Fixed! Turns out my |
|
Thank you for this!
Yes, tests are not nearly comprehensive enough and the benchmarks are also severely lacking. Even so CI already helped me catch a lot of issues (even found a bug in SBCL) and is worth investing in: I'll take a look at how other client libraries do this as there might be some low-hanging fruits here as well. |
This mostly finishes my plan to improve
translate-result:translate-value-caseandtranslate-compositehas been rewritten as methods oftranslate-vector, and the "slow path" method that does type dispatch inside the loop over vector data is eliminated ;)There are still areas for improvement, e.g. various
translate-from-foreigncalls, but so far it's good enough for my work and I can eschew hacks in mylocal-project! Moreover, becausetranslate-vectoris now extensible, I can plug in whatever domain specific hack as methods (e.g. I have an unboxed representation of timestamp that works with Petalisp).