+
Skip to content
This repository was archived by the owner on Sep 17, 2024. It is now read-only.

feat/auto-update #562

Merged
merged 14 commits into from
Mar 13, 2021
Merged

feat/auto-update #562

merged 14 commits into from
Mar 13, 2021

Conversation

tarkah
Copy link
Member

@tarkah tarkah commented Mar 12, 2021

Proposed Changes

  • Add feature to automatically check for new updates on interval
  • Also add option to enable applying new updates automatically

Checklist

  • Tested on Windows
  • Tested on MacOS
  • Tested on Linux
  • Added an entry to CHANGELOG.md if knowledge of this change could be valuable to users

@tarkah
Copy link
Member Author

tarkah commented Mar 12, 2021

@casperstorm Test this out. I've currently only implemented "checking" for new updates. It's hard-coded to check every 30 minutes. Should we make that configurable or is 30mins sane? Considering how slow to update Curse API is, not sure that matters too much.

Adding the ability to apply these updates automatically will be trivial. I'll make sure that's opt-in via config.

When an update is found for the Flavor, it'll resort the addons by status to push those updates to the top of the screen.

@casperstorm
Copy link
Member

This is a great PR, @tarkah. It looks great.

Should we make that configurable or is 30mins sane? Considering how slow to update Curse API is, not sure that matters too much.

I have thought about it for a while and initially I wanted to make it quite customisable with a drop-down of different intervals, but then again... why? As you also mention we are limited by the API and 30mins should be MORE than enough and would simplify the GUI (and UX) a lot. I suggest we add a checkbox to enable "auto update" and enable auto refresh for everyone.

The auto refresh i feel is a QOL thing everyone would benefit from.

@tarkah
Copy link
Member Author

tarkah commented Mar 12, 2021

@casperstorm I 100% agree with you. Worst case, we get people asking for control and we can add the interval down the road.

@tarkah tarkah marked this pull request as ready for review March 12, 2021 19:04
@tarkah tarkah requested a review from casperstorm March 12, 2021 19:04
@casperstorm
Copy link
Member

casperstorm commented Mar 13, 2021

@tarkah I've removed the test in localization.rs because we often forgot to add keys and we don't really need it now since everything comes from poeditor and they handle that all languages has the same terms.

Other than that all is LGTM! It has been tested and works.

@tarkah tarkah merged commit 1ac5da3 into development Mar 13, 2021
@tarkah tarkah deleted the feat/auto-update branch March 13, 2021 17:30
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
点击 这是indexloc提供的php浏览器服务,不要输入任何密码和下载