+
Skip to content
This repository was archived by the owner on Sep 17, 2024. It is now read-only.

For users with only a single account, automatically pick the account when in the weak aura view #546

Merged
merged 4 commits into from
Feb 21, 2021
Merged

For users with only a single account, automatically pick the account when in the weak aura view #546

merged 4 commits into from
Feb 21, 2021

Conversation

nkf
Copy link
Contributor

@nkf nkf commented Feb 21, 2021

Resolves #

Proposed Changes

  • For users with only a single account, automatically pick the account when in the weak aura view

Checklist

  • Tested on Windows
  • Tested on MacOS
  • Tested on Linux
  • Added an entry to CHANGELOG.md if knowledge of this change could be valuable to users

@nkf nkf marked this pull request as draft February 21, 2021 13:42
@nkf nkf force-pushed the single-account-auto-select branch from 21f30c5 to 0eacc9c Compare February 21, 2021 13:56
@nkf nkf marked this pull request as ready for review February 21, 2021 13:59
casperstorm
casperstorm suggested changes Feb 21, 2021
View reviewed changes
Copy link
Member

@casperstorm casperstorm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great addition, i really love these QOL changes. Also welcome to the contributor team. It's nice to see new people help out on Ajour!

@nkf nkf force-pushed the single-account-auto-select branch from 616d2d2 to eb4b742 Compare February 21, 2021 14:58
@casperstorm casperstorm changed the base branch from master to development February 21, 2021 15:08
@nkf
Copy link
Contributor Author

nkf commented Feb 21, 2021

Nice!

Thanks for creating this awesome tool.

Do you use rust-analyzer for this by any chance? I couldn't get it to work for this project, it just never completes the initial analysis

@casperstorm
Copy link
Member

Nice!

Thanks for creating this awesome tool.

Do you use rust-analyzer for this by any chance? I couldn't get it to work for this project, it just never completes the initial analysis

I use rust-analyzer! However @tarkah has reported problems on his end with it as well. 🤔

@tarkah
Copy link
Member

tarkah commented Feb 21, 2021 •
edited
Loading

Yeah I have to use Rust-Analyzer releases that are ~3+ months old, otherwise it always fails when opening gui/update.rs. It's very annoying.

@tarkah
Copy link
Member

tarkah commented Feb 21, 2021

Also, great addition! I love the pattern match on a single item slice

@casperstorm
Copy link
Member

@nkf can i get you to update CHANGELOG.md?

@nkf
Copy link
Contributor Author

nkf commented Feb 21, 2021

@nkf can i get you to update CHANGELOG.md?

Sure, I wasn't sure if this was too trivial to go into the changelog, ill update the log :)

@casperstorm casperstorm merged commit be1bde6 into ajour:development Feb 21, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@casperstorm casperstorm casperstorm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nkf @casperstorm @tarkah
点击 这是indexloc提供的php浏览器服务，不要输入任何密码和下载