+
Skip to content
This repository was archived by the owner on Sep 17, 2024. It is now read-only.

feat: context localizations #521

Merged
merged 5 commits into from
Jan 30, 2021

Conversation

casperstorm
Copy link
Member

Proposed Changes

  • Quite a few error has not yet been localized.

Checklist

  • Tested on Windows
  • Tested on MacOS
  • Tested on Linux
  • Added an entry to CHANGELOG.md if knowledge of this change could be valuable to users

@casperstorm casperstorm changed the base branch from development to fix/language-updates January 29, 2021 19:37
@casperstorm casperstorm marked this pull request as draft January 29, 2021 19:50
@casperstorm
Copy link
Member Author

@tarkah Would you be able to look at getting a generic "IO error" for the error-update-ajour as we talked about on Discord? Im a little unsure how to do it with the context and AnyHow 🤔 I am thinking we can have a error-io-update-ajour for it, or just use the other if we only want one?

@tarkah
Copy link
Member

tarkah commented Jan 29, 2021

Sounds good! I'll at least add the code to match the downcasted error on IO error and log things so we can test what actually happens when we try to self update from a folder we don't have permissions to. Then you can play around with an error message for it.

@tarkah
Copy link
Member

tarkah commented Jan 29, 2021

@casperstorm Check out my latest commit, it should make sense how I'm downcasting to check for io error / permissions issue. I've not added the "key" for localization yet, figured you could mess with that.

Note I modified the version so we could test the self update feature and I tested by copying to my C:\ root and was able to get the custom context for permissions issue! Make sure to revert version before merging.

@casperstorm
Copy link
Member Author

Make sense, and works perfectly!

@casperstorm casperstorm marked this pull request as ready for review January 30, 2021 07:09
@casperstorm casperstorm merged commit 284bd82 into fix/language-updates Jan 30, 2021
@casperstorm casperstorm deleted the feat/context-localizations branch January 30, 2021 07:16
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
点击 这是indexloc提供的php浏览器服务,不要输入任何密码和下载