+
Skip to content
This repository was archived by the owner on Sep 17, 2024. It is now read-only.

add git source #333

Merged
merged 34 commits into from
Nov 11, 2020
Merged

add git source #333

merged 34 commits into from
Nov 11, 2020

Conversation

tarkah
Copy link
Member

@tarkah tarkah commented Nov 3, 2020

Proposed Changes

  • Rewrote parsing engine in Ajour
  • Able to add GitHub/GitLab addons through a URL

Checklist

  • Tested on all platforms changed
  • Added an entry to CHANGELOG.md if knowledge of this change could be valuable to users

@tarkah
Copy link
Member Author

tarkah commented Nov 3, 2020

@casperstorm I have the major refactor done that I was talking about and the beginning of the git piece already added. I need to go back through the code and make a lot of comments and audit all my changes to make sure I didn't overlook anything. A basic test seems like everything is working as before.

@casperstorm casperstorm linked an issue Nov 4, 2020 that may be closed by this pull request
@tarkah tarkah linked an issue Nov 5, 2020 that may be closed by this pull request
@tarkah
Copy link
Member Author

tarkah commented Nov 6, 2020

@casperstorm this is in a really good spot with Git support. You can test by installing repos from the command line via ajour install --help

The last thing that needs to be built out is a way to add the git repo from the GUI. Have you put anymore though into how you'd like to present this in the GUI?

@casperstorm
Copy link
Member

I'll test and make GUI design today.

@tarkah
Copy link
Member Author

tarkah commented Nov 8, 2020

@casperstorm I connected the install path for git to the gui. The button updates it's text just like catalog, and if an error is encountered, I feed that error text to a new error text container. Once the addon is succesfully installed, I show the install button as "Installed" and disabled. This will also work on already installed git addons, if it shares the URL with what is typed in, it'll recognize it as already installed.

@casperstorm
Copy link
Member

A few things when you have time, @tarkah:

  • When you install Details from and refresh it does not correctly group it

Screenshot 2020-11-08 at 19 58 54

  • I think we should reset state someway. One way I thought was as soon as you write something in the query we reset to install - this would fix both completed and error.

  • Update UI and come up with a better name. This i'll handle.

@tarkah tarkah force-pushed the feat/add-git-source branch from 2052cd6 to b74f320 Compare November 8, 2020 21:43
@tarkah
Copy link
Member Author

tarkah commented Nov 8, 2020

@casperstorm I fixed the fingerprint issue... we were using an already escaped string sequence, but putting it in the r"" raw string literal -_____-

@tarkah
Copy link
Member Author

tarkah commented Nov 8, 2020

@casperstorm Ok, so now Enter and the button are disabled if already installed / an error is encountered. Once user input is received in the text box, this resets the status. Try it out!

@casperstorm
Copy link
Member

LGTM. We should soon get it to development I think!

@tarkah
Copy link
Member Author

tarkah commented Nov 9, 2020

sounds good! I'll backmerge and wait for @mlablah to do some initial testing, then we can merge

@casperstorm
Copy link
Member

sounds good! I'll backmerge and wait for @mlablah to do some initial testing, then we can merge

I'll do some more testing today as well.

@tarkah tarkah marked this pull request as ready for review November 11, 2020 19:55
@tarkah tarkah merged commit cb42800 into development Nov 11, 2020
@tarkah tarkah deleted the feat/add-git-source branch November 11, 2020 19:55
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TukUI addon using title from toc Install addon from github repo
2 participants
点击 这是indexloc提供的php浏览器服务,不要输入任何密码和下载