+
Skip to content
This repository was archived by the owner on Sep 17, 2024. It is now read-only.

feat: tukui addons #226

Closed
wants to merge 9 commits into from
Closed

feat: tukui addons #226

wants to merge 9 commits into from

Conversation

petergam
Copy link
Collaborator

@petergam petergam commented Oct 11, 2020

Proposed Changes

  • Uses catalog feed to show both curse and tukui addons in catalog
  • Append X-Tukui-ProjectID to toc file for Tukui addons with that field missing (only support for archives containing just 1 addon. Some archives from tukui are a collection of addons)

Most tukui addons work, but some doenst because the zip archive contains multiple addons and the main one doenst have the X-Tukui-ProjectID key set. I haven't found a reliable way where I can detect which of the addons in an archive with multiple that I should add the id to. My suggestion is that we blocklist addons that we know is not working in the catalog.

Checklist

  • Tested on all platforms changed
  • Added an entry to CHANGELOG.md if knowledge of this change could be valuable to users

@casperstorm
Copy link
Member

One thing we could try as well before we merge is to group the addon once they are installed.
So if we unzip a addon into A, B and C and we know the addon is called "ABC Awesome" we will note it down in ajour.yml:

Eg:

Grouped:
  - ABC:
    - Folders:
       - A
       - B
       - C
    - Hash: 1234

Not sure what would be relevant to save, but it would make sense maybe to think in that direction because then this would also work for Wowinterface were we will have the same problem.
Obviously this wont work if they install it from any other place than Ajour.

@casperstorm
Copy link
Member

We should get this back-merged so we can merge it together with #315.

@tarkah
Copy link
Member

tarkah commented Oct 29, 2020

@casperstorm I've enabled the Tukui catalog already in #315. I assume we don't want to modify .toc entries from this PR as we now have the cache?

@casperstorm
Copy link
Member

@casperstorm I've enabled the Tukui catalog already in #315. I assume we don't want to modify .toc entries from this PR as we now have the cache?

True. Forgot this was more than just enabling catalog.

@casperstorm
Copy link
Member

Closing for now in favor for the new caching system.

@tarkah tarkah deleted the feat/tukui-addons branch November 2, 2020 17:46
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants
点击 这是indexloc提供的php浏览器服务,不要输入任何密码和下载