+
Skip to content

Caffeine cache #432

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 16, 2025
Merged

Caffeine cache #432

merged 1 commit into from
Oct 16, 2025

Conversation

jjaakola-aiven
Copy link
Contributor

Remove Infinispan and use Caffeine instead.
Requires consistent broker selection to be effective.

@jjaakola-aiven jjaakola-aiven force-pushed the jjaakola-aiven-caffeine-but-with-full-fetch branch from 4979ad0 to f55a70a Compare October 16, 2025 08:32
@jjaakola-aiven
Copy link
Contributor Author

Optimistic caching in the FileCommiter creates a CacheStoreJob and submits task to executor. This could be streamlined in later PR as local Caffeine cache should be faster than distributed Infinispan. Infinispan will store the data to owner cache node, owner may not be the local node and storing does network hops.

@jjaakola-aiven jjaakola-aiven marked this pull request as ready for review October 16, 2025 08:36
jeqo
jeqo previously approved these changes Oct 16, 2025
View reviewed changes
Copy link
Contributor

@jeqo jeqo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Agree that we can do further optimizations from here. Thanks @jjaakola-aiven

@jjaakola-aiven jjaakola-aiven force-pushed the jjaakola-aiven-caffeine-but-with-full-fetch branch from f55a70a to ef6aac3 Compare October 16, 2025 09:37
@jjaakola-aiven jjaakola-aiven force-pushed the jjaakola-aiven-caffeine-but-with-full-fetch branch from ef6aac3 to fc3d13f Compare October 16, 2025 09:43
@jeqo jeqo merged commit d2b3a54 into main Oct 16, 2025
4 checks passed
@jeqo jeqo deleted the jjaakola-aiven-caffeine-but-with-full-fetch branch October 16, 2025 11:32
jeqo pushed a commit that referenced this pull request Oct 16, 2025
@jjaakola-aiven @jeqo
cache: use caffeine with full fetches (#432)
d93b847
jeqo pushed a commit that referenced this pull request Oct 16, 2025
@jjaakola-aiven @jeqo
cache: use caffeine with full fetches (#432)
9b2b918
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jeqo jeqo jeqo approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jjaakola-aiven @jeqo
点击 这是indexloc提供的php浏览器服务，不要输入任何密码和下载