feat: enable allowUnknownFlags for specific commands #4921
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks @Melchyore 🙏 |
Many thanks for accepting this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔗 Linked issue
❓ Type of change
📚 Description
According to the AdonisJS documentation, commands can accept unknown flags, which can be used in stubs to customize behavior such as output destination.
However, by default, the allowUnknownFlags option is disabled, preventing this feature from working as intended.
This PR enables the allowUnknownFlags option for specific commands that benefit from accepting and using additional flags—restoring alignment with the documented behavior. This is useful when using modular architecture.
If this PR is approved and merged, similar changes will be proposed for other packages like Lucid, Mail, and so on.(Edit: It appears that other packages have already enabled this option for make commands)📝 Checklist