+
Skip to content

Labeler removed human-applied label with no labeler config #908

@jnewland

Description

@jnewland

Description:
This action removed a label I applied to a PR manually around the same time that a labeler action was running. The label removed was not configured in labeler.yml.

#763 describes a similar situation and seems to have been closed without resolution.

Action version:
6.0.1

Platform:

  • Ubuntu
  • macOS
  • Windows

Runner type:

  • Hosted
  • Self-hosted

Repro steps:

Add any label to a PR while this action is running.

Workflow

      - uses: actions/labeler@634933edcd8ababfe52f92936142cc22ac488b1b # v6.0.1
        with:
          sync-labels: true
Config
documentation:
  - changed-files:
      - any-glob-to-any-file: "**/*.md"
xcode:
  - changed-files:
      - any-glob-to-any-file: "**/*.resolved"
      - any-glob-to-any-file: "**/*.xcodeproj"
      - any-glob-to-any-file: "**/*.entitlements"
      - any-glob-to-any-file: "**/.pbxproj"
      - any-glob-to-any-file: "**/Gemfile"
      - any-glob-to-any-file: "**/Podfile"
      - any-glob-to-any-file: "**/*file.lock"
      - any-glob-to-any-file: "**/*.plist"
      - any-glob-to-any-file: "**/*.json"
swift:
  - changed-files:
      - any-glob-to-any-file: "**/*.swift"
tests:
  - changed-files:
      - any-glob-to-any-file: "**/*Tests.swift"
"app store":
  - changed-files:
      - any-glob-to-any-file: fastlane/**
      - any-glob-to-any-file: static/**
GitHub:
  - changed-files:
      - any-glob-to-any-file: .github/**
      - any-glob-to-any-file: .vscode/**
      - any-glob-to-any-file: script/**
      - any-glob-to-any-file: "*"
tvOS:
  - changed-files:
      - any-glob-to-any-file: "**/TV**.swift"
      - any-glob-to-any-file: "Bops Now Playing/**"
iOS:
  - changed-files:
      - any-glob-to-any-file: "Bops/**"

Expected behavior:

Even with sync-labels: true, this action should never remove a label that it is not configured to manage.

Actual behavior:

This action creates a small window of time during which any human-applied label may be removed.

Image

Metadata

Metadata

Labels

bugSomething isn't working

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions

    点击 这是indexloc提供的php浏览器服务,不要输入任何密码和下载