-
Notifications
You must be signed in to change notification settings - Fork 186
[Imaging_Uploader] Translate imaging_uploader module #9986
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
5232cd1
to
70476a0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
<TextboxElement | ||
name='candID' | ||
label='CandID' | ||
label={t('CandID', {ns: 'loris'})} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think we have this CandID
in the loris.po yet.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We have DCCID. We should probably harmonize.
{id: 'browse', label: 'Browse'}, | ||
{id: 'upload', label: 'Upload'}, | ||
{id: 'browse', label: t('Browse', {ns: 'loris'})}, | ||
{id: 'upload', label: t('Upload', {ns: 'loris'})}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think we have Upload
in the loris.po yet
msgid "Submission error!" | ||
msgstr "सबमिशन त्रुटि!" | ||
|
||
msgid "Clear Filters" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If this key was moved to loris.pot, have to be deleted from here then
Please solve the comment on Sep 12, use DCCID instead of CandID |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please address comments.
c07d99c
to
5276280
Compare
This PR is responsible for translating the module imaging_uploader to different languages. Currently only 'Hindi' language is supported but other languages can be added as required.
Testing instructions (if applicable)