+
Skip to content

Conversation

SKADE2303
Copy link
Collaborator

This PR is responsible for translating the module imaging_uploader to different languages. Currently only 'Hindi' language is supported but other languages can be added as required.

Testing instructions (if applicable)

  • Run 'make dev' to load changes
  • Change language_preference to Hindi in my_preferences Tab
  • Go to imaging_uploader tab to see translated web page.

@github-actions github-actions bot added Language: Javascript PR or issue that update Javascript code Module: imaging_uploader PR or issue related to imaging_uploader module labels Aug 29, 2025
@SKADE2303 SKADE2303 added Event: GSOC PR or issue accepted for Google Summer of Code Multilingual Any tasks related to making LORIS multilingual labels Aug 29, 2025
@SKADE2303 SKADE2303 requested a review from racostas August 29, 2025 19:47
@SKADE2303 SKADE2303 force-pushed the TranslateImagingUploader branch from 5232cd1 to 70476a0 Compare August 29, 2025 19:48
Copy link
Contributor

@racostas racostas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some translations still missing.
image

If they are in a PR that is not merge yet, please add the blocked and blocking labels. Also a link to the PR(s) itself.

<TextboxElement
name='candID'
label='CandID'
label={t('CandID', {ns: 'loris'})}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we have this CandID in the loris.po yet.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have DCCID. We should probably harmonize.

{id: 'browse', label: 'Browse'},
{id: 'upload', label: 'Upload'},
{id: 'browse', label: t('Browse', {ns: 'loris'})},
{id: 'upload', label: t('Upload', {ns: 'loris'})},
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we have Upload in the loris.po yet

@racostas racostas added the State: Needs work PR awaiting additional work by the author to proceed label Sep 12, 2025
@SKADE2303 SKADE2303 removed the State: Needs work PR awaiting additional work by the author to proceed label Oct 6, 2025
msgid "Submission error!"
msgstr "सबमिशन त्रुटि!"

msgid "Clear Filters"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If this key was moved to loris.pot, have to be deleted from here then

@racostas
Copy link
Contributor

Please solve the comment on Sep 12, use DCCID instead of CandID

@racostas racostas self-requested a review October 14, 2025 19:31
Copy link
Contributor

@racostas racostas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please address comments.

@SKADE2303 , @christinerogers

@SKADE2303 SKADE2303 force-pushed the TranslateImagingUploader branch from c07d99c to 5276280 Compare October 16, 2025 19:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Event: GSOC PR or issue accepted for Google Summer of Code Language: Javascript PR or issue that update Javascript code Module: imaging_uploader PR or issue related to imaging_uploader module Multilingual Any tasks related to making LORIS multilingual

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

点击 这是indexloc提供的php浏览器服务,不要输入任何密码和下载