+
Skip to content

Conversation

shonibare
Copy link
Contributor

…nd project

Fixes #6591

To Test

  1. Create a user with the following permission only:

Imaging Quality Control: View Flagged Imaging Entries

Make sure not to include View all-sites Imaging Browser pages or any other permissions
2. Assign the user site e.g "Ottawa" and project "Pumpernickel"
3. Log in as this user, and navigate to the imaging quality control module
4. Observe that the front page loads with data pertaining only to the user site and project
5. Observe that the site filter only allows filtering only to the user's site
6. Observe that the project filter allows filtering only to the user's project

@shonibare shonibare changed the title [image_qc] fix module to display only data affliated to user's site a… [imaging_qc] fix module to display only data affliated to user's site a… Oct 10, 2024
@skarya22 skarya22 self-requested a review October 29, 2024 15:05
@skarya22
Copy link
Contributor

My user with Challah and Rome could see scans from other projects
image

@skarya22 skarya22 assigned shonibare and unassigned skarya22 Oct 31, 2024
@skarya22 skarya22 added the State: Needs work PR awaiting additional work by the author to proceed label Oct 31, 2024
Copy link
Contributor

@skarya22 skarya22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix so that scans from projects the user does not have do not show.

@shonibare shonibare requested a review from skarya22 November 2, 2024 23:56
Copy link
Contributor

@skarya22 skarya22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@skarya22 skarya22 added Passed manual tests PR has been successfully tested by at least one peer and removed State: Needs work PR awaiting additional work by the author to proceed labels Nov 4, 2024
@driusan
Copy link
Collaborator

driusan commented Nov 7, 2024

If a user has sites A, B, and C and a candidate has sites C, and D, my understanding of this change is that it will make it so that the user sees the candidate but it only shows it as having site "C". Is that correct?

If so, I think it should be discussed at a LORIS meeting.

@shonibare
Copy link
Contributor Author

If a user has sites A, B, and C and a candidate has sites C, and D, my understanding of this change is that it will make it so that the user sees the candidate but it only shows it as having site "C". Is that correct?

If so, I think it should be discussed at a LORIS meeting.

@driusan Yes, you are right. The page should only display data from the sites and projects to which the user has access, as well as the site and project filters as reported in the issue.

@ridz1208 ridz1208 changed the title [imaging_qc] fix module to display only data affliated to user's site a… [imaging_qc] fix module to display only data affliated to user's site and project Jan 13, 2025
@driusan driusan merged commit 5642bb2 into aces:main Mar 10, 2025
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Passed manual tests PR has been successfully tested by at least one peer

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[imaging_qc] module displays data not included in the user's project and site affiliations

3 participants

点击 这是indexloc提供的php浏览器服务,不要输入任何密码和下载