[media] fixes issue when media module try to instantiate a non existing instrument. #8903
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Why can the instrument not be instantiated? That sounds like a deeper problem with the instrument that should be fixed. |
|
@racostas I like the try catch, but I think other than the error log maybe a warning alert on the browser saying something like "Uploads to instrument BLA were not loaded due to an error" something along these lines so that it doesnt go unnoticed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Brief summary of changes
A try catch block was added to prevent the module to break if for any reason one of the instruments could not be instantiated. Pleas refer to issue #8902
Testing instructions (if applicable)
MainMenu->Clinical->MediaLink(s) to related issue(s)