Migrate Advisory aliases field to M2M relationship #1784
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
keshav-space
commented
Feb 21, 2025
- resolves VCIO-next: Migrate Advisory aliases from JSON field to M2M relationship #1777
3131477 to
2551014
Compare
Signed-off-by: Keshav Priyadarshi <git@keshav.space>
Signed-off-by: Keshav Priyadarshi <git@keshav.space>
Signed-off-by: Keshav Priyadarshi <git@keshav.space>
Signed-off-by: Keshav Priyadarshi <git@keshav.space>
Signed-off-by: Keshav Priyadarshi <git@keshav.space>
- Also validate fields before saving Signed-off-by: Keshav Priyadarshi <git@keshav.space>
Signed-off-by: Keshav Priyadarshi <git@keshav.space>
Signed-off-by: Keshav Priyadarshi <git@keshav.space>
2551014 to
04cab61
Compare
TG1999
reviewed
Mar 25, 2025
TG1999
reviewed
Mar 25, 2025
|
@keshav-space LGTM! few nits for your consideration. Also please run a few importers and improvers locally and provide logs for them here. Additionally report the status of migration/pipeline once tested locally. |
Signed-off-by: Keshav Priyadarshi <git@keshav.space>
Signed-off-by: Keshav Priyadarshi <git@keshav.space>
Signed-off-by: Keshav Priyadarshi <git@keshav.space>
- Since unique_content_id is a proxy for other fields using it is enough and sufficient. Signed-off-by: Keshav Priyadarshi <git@keshav.space>
- Use AdvisoryRelatedAlias to manage advisory alias relation Signed-off-by: Keshav Priyadarshi <git@keshav.space>
…s-to-concrete-relation
|
@TG1999 here are the logs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.