+
Skip to content

Conversation

TG1999
Copy link
Contributor

@TG1999 TG1999 commented Dec 20, 2024

Copy link
Member

@pombredanne pombredanne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Here are a few comments for your consideration.
IMHO I am not sure we want a PURL for a commit, we should consider using vcs URLs rather than a plain commit id...

I am open to something else that we can design, but if we do that we need a way to get back to the commit.

We are going to have cases that are NOT on GitHub and therefore are just plain git coordinates.

if commit_id and package_urls:
for purl in package_urls:
normalized_purl = normalize_purl(purl)
package = self.get_or_create_package(normalized_purl)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we really want to create new packages here? I would have thought we are only adding new CodeFix?

@TG1999 TG1999 changed the title Add models for CodeFix WIP: Add models for CodeFix Jan 1, 2025
@TG1999 TG1999 marked this pull request as draft January 1, 2025 13:41
TG1999 added 8 commits January 8, 2025 19:17
Signed-off-by: Tushar Goel <tushar.goel.dav@gmail.com>
Signed-off-by: Tushar Goel <tushar.goel.dav@gmail.com>
Signed-off-by: Tushar Goel <tushar.goel.dav@gmail.com>
Signed-off-by: Tushar Goel <tushar.goel.dav@gmail.com>
Signed-off-by: Tushar Goel <tushar.goel.dav@gmail.com>
Signed-off-by: Tushar Goel <tushar.goel.dav@gmail.com>
Signed-off-by: Tushar Goel <tushar.goel.dav@gmail.com>
Signed-off-by: Tushar Goel <tushar.goel.dav@gmail.com>
@TG1999 TG1999 force-pushed the collect_fix_commits branch from 2b66214 to 7bb44be Compare January 8, 2025 14:52
@TG1999
Copy link
Contributor Author

TG1999 commented Jan 8, 2025

Screenshot from 2025-01-08 20-21-06

Screenshot from 2025-01-08 20-21-28
API support is also added!

@TG1999 TG1999 changed the title WIP: Add models for CodeFix Add models for CodeFix Jan 8, 2025
Signed-off-by: Tushar Goel <tushar.goel.dav@gmail.com>
@TG1999 TG1999 marked this pull request as ready for review January 8, 2025 14:57
Signed-off-by: Tushar Goel <tushar.goel.dav@gmail.com>
Copy link
Member

@keshav-space keshav-space left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @TG1999, LGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

VCIO-next: Create improver to find fix commits VCIO-next: Add support to track fix commits: Include commits and patches that fix a vulnerability

3 participants

点击 这是indexloc提供的php浏览器服务,不要输入任何密码和下载