Add base pipeline for importers and migrate PyPa importer to aboutcode pipeline #1559
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
keshav-space
commented
Aug 20, 2024
- Reference: Use the SCIO Pipeline Mechanism for Importers/Improvers #1509
36 tasks
1364361 to
567f1ec
Compare
pombredanne
reviewed
Aug 26, 2024
|
|
||
| def advisories_count(self): | ||
| vulns_path = Path(self.vcs_response.dest_dir) / "vulns" | ||
| return sum(1 for _ in vulns_path.rglob("*.yaml")) |
There was a problem hiding this comment.
What about this too? or is this to avoid using too much memory?
Suggested change
| return sum(1 for _ in vulns_path.rglob("*.yaml")) | |
| return len(list(vulns_path.rglob("*.yaml"))) |
There was a problem hiding this comment.
Yes, did that to avoid keeping all the Path objects in memory at the same time.
Signed-off-by: Keshav Priyadarshi <git@keshav.space>
Signed-off-by: Keshav Priyadarshi <git@keshav.space>
Signed-off-by: Keshav Priyadarshi <git@keshav.space>
Signed-off-by: Keshav Priyadarshi <git@keshav.space>
Signed-off-by: Keshav Priyadarshi <git@keshav.space>
Signed-off-by: Keshav Priyadarshi <git@keshav.space>
Signed-off-by: Keshav Priyadarshi <git@keshav.space>
Signed-off-by: Keshav Priyadarshi <git@keshav.space>
Signed-off-by: Keshav Priyadarshi <git@keshav.space>
567f1ec to
d73cfd4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.