+
Skip to content

Add support to find source repo for a package #137

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 27, 2023
Merged

Add support to find source repo for a package #137

merged 2 commits into from
Jul 27, 2023

Conversation

TG1999
Copy link
Contributor

@TG1999 TG1999 commented Jul 3, 2023

No description provided.

@pombredanne pombredanne mentioned this pull request Jul 3, 2023
Open
@TG1999 TG1999 force-pushed the find_source_repo branch 2 times, most recently from 68c8882 to 5b04be0 Compare July 5, 2023 16:21
@TG1999 TG1999 requested review from JonoYang and pombredanne July 5, 2023 16:22
@TG1999 TG1999 force-pushed the find_source_repo branch from 5b04be0 to 595db03 Compare July 5, 2023 16:46
JonoYang
JonoYang requested changes Jul 6, 2023
View reviewed changes
Copy link
Member

@JonoYang JonoYang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@TG1999 Thanks for the PR! I've left some comments regarding the use of list indexes and readability.

@TG1999 TG1999 force-pushed the find_source_repo branch 2 times, most recently from 3633209 to d2139dc Compare July 6, 2023 10:41
@TG1999 TG1999 requested a review from JonoYang July 6, 2023 10:44
@TG1999 TG1999 force-pushed the find_source_repo branch 3 times, most recently from 3811722 to 43aa074 Compare July 10, 2023 10:57
@TG1999 TG1999 force-pushed the find_source_repo branch 9 times, most recently from cad569d to 0d7ed31 Compare July 20, 2023 16:57
JonoYang
JonoYang requested changes Jul 21, 2023
View reviewed changes
Copy link
Member

@JonoYang JonoYang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@TG1999 I've left some comments for you

packagedb/find_source_repo.py Outdated
source_purls = list(convert_repo_urls_to_purls(repo_urls))
if not source_purls:
return
source_purls = set(list(source_purls))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you trying to dedup source_purls?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes!

@TG1999 TG1999 force-pushed the find_source_repo branch 6 times, most recently from 0d4aad5 to 8e40335 Compare July 26, 2023 06:05
@TG1999
Add support to find source repo for a package
1d59324 
Signed-off-by: Tushar Goel <tushar.goel.dav@gmail.com>
@TG1999 TG1999 force-pushed the find_source_repo branch from 8e40335 to 1d59324 Compare July 26, 2023 06:18
JonoYang
JonoYang requested changes Jul 27, 2023
View reviewed changes
Copy link
Member

@JonoYang JonoYang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@TG1999 Thanks for the changes! I have some small things for you to revise, but your code looks alright and I will try out the source repo package creation tomorrow.

@TG1999
Address review comments
17236ac 
Signed-off-by: Tushar Goel <tushar.goel.dav@gmail.com>
@JonoYang JonoYang self-requested a review July 27, 2023 23:11
JonoYang
JonoYang approved these changes Jul 27, 2023
View reviewed changes
Copy link
Member

@JonoYang JonoYang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@TG1999 LGTM!

@JonoYang JonoYang merged commit 802ef95 into main Jul 27, 2023
@TG1999 TG1999 mentioned this pull request Aug 11, 2023
Closed
@pombredanne pombredanne deleted the find_source_repo branch September 21, 2023 11:30
JonoYang added a commit that referenced this pull request Apr 14, 2025
@JonoYang
Merge pull request #137 from nexB/find_source_repo
78e524b 
Add support to find source repo for a package
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JonoYang JonoYang JonoYang approved these changes

@pombredanne pombredanne Awaiting requested review from pombredanne

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@TG1999 @pombredanne @JonoYang
点击 这是indexloc提供的php浏览器服务，不要输入任何密码和下载