feat: Add logging to file #2781
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This uses tracing appender and combines with the default stdout writer that comes from `fmt::layer`. Signed-off-by: Taylor Thomas <taylor@oftaylor.com>
thomastaylor312
commented
Jun 5, 2025
| tokio::fs::create_dir_all(&log_dir) | ||
| .await | ||
| .wrap_err("could not create log directory")?; | ||
| let appender = RollingFileAppender::builder() |
There was a problem hiding this comment.
This seemed like a decent idea so the log wouldn't grow forever, but we can also just do a plain file as well
thomastaylor312
commented
Jun 5, 2025
crates/atuin/src/command/client.rs
Outdated
| let appender = RollingFileAppender::builder() | ||
| .filename_prefix("atuin.log") | ||
| .rotation(Rotation::DAILY) | ||
| .max_log_files(7) |
There was a problem hiding this comment.
I would probably make this configurable if we want to keep the rotating appender around. If we do, should this just be an env var or also exposed in settings?
There was a problem hiding this comment.
I added an env var for now just in case. Easy enough to pop off or modify depending on feedback!
|
In draft so I can get some feedback on the comments above. If there was a different idea in mind, please let me know. This wasn't too difficult so easy enough to throw away and take another approach |
This configures the total number of days of logs that should be kept Signed-off-by: Taylor Thomas <taylor@oftaylor.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This uses tracing appender and combines with the default stdout writer that comes from
fmt::layer.Closes #87
Checks