TEMPLATE - add trainling slash for pipelines_testdata_base_path #3701
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
from @vagkaratzas > Would it be too much pain to put a slash at the end of pipelines_testdata_base_path in tests/nextflow.config, in the next template update? Currently it's different to the modules_testdata_base_path above. Would be nice to have uniformity in tests throughout conf/ tests/ and modules-subworkflows tests. I've left a relevant though-comment on this PR: nf-core/methylseq#558 (comment)
mirpedrol
reviewed
Aug 12, 2025
There was a problem hiding this comment.
Thanks for the change!
I am wondering if we should also update the path in the nf_core/pipeline-template/nextflow.config and nf_core/pipeline-template/nextflow_schema.json files to avoid confusion. But this will be a big change where all pipelines will have to update their tests, so we should think about it, to make sure it doesn't break too many things.
|
good question, maybe we should indeed |
|
hmm, not sure it's worth the template merge pain to be honest. Maybe we can bookmark the change and do it in the future, together with other changes that we may need to make then? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
from @vagkaratzas
PR checklist
CHANGELOG.mdis updateddocsis updated