Update nf-test.yml #3673
Update nf-test.yml #3673
Conversation
removing conditions
|
I don't understand why CI mode would help us in this situations? |
There was a problem hiding this comment.
I also don't see why we should run nf-test if we are only modifying documentation (md, png, etc.) If modifying one of these files affects the output of the pipeline, I would consider it a particularity of one single pipeline and would change it only for that pipeline.
| - "**/*.md" | ||
| - "**/*.png" | ||
| - "**/*.svg{% raw %}" | ||
| pull_request:{% raw %}" |
There was a problem hiding this comment.
This {% raw %} should be moved, I think it's going to cause problems if we keep it here. Can go to line 10.
CI mode should detect that these files do not impact the pipeline, and hence not run tests |
|
But it is better to not run the CI at all than spinning up machines to then do nothing |
Totally agreeing with you, but isn't the expected confirm-pass making issues in such a case? |
Wondering if we need to disable actions when modifying only md/svg/pdf since nf-test is run in ci mode
PR checklist
CHANGELOG.mdis updateddocsis updated