+
Skip to content

Increased test coverage #994

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Apr 8, 2021
Merged

Increased test coverage #994

merged 4 commits into from
Apr 8, 2021

Conversation

ErikDanielsson
Copy link
Contributor

Added a few more test for utils and linting.

PR checklist

  • This comment contains a description of changes (with reason)
  • CHANGELOG.md is updated
  • If you've fixed a bug or added code that should be tested, add tests!
  • Documentation in docs is updated

@codecov
Copy link

codecov bot commented Apr 8, 2021 •
edited
Loading

Codecov Report

Merging #994 (8130417) into dev (d0a6649) will increase coverage by 0.44%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev     #994      +/-   ##
==========================================
+ Coverage   69.30%   69.74%   +0.44%     
==========================================
  Files          34       34              
  Lines        4225     4261      +36     
==========================================
+ Hits         2928     2972      +44     
+ Misses       1297     1289       -8
Impacted Files Coverage Δ
nf_core/lint/conda_dockerfile.py 81.25% <0.00%> (-6.25%) ⬇️
nf_core/schema.py 85.55% <0.00%> (-0.96%) ⬇️
nf_core/sync.py 51.50% <0.00%> (-0.49%) ⬇️
nf_core/launch.py 66.75% <0.00%> (-0.01%) ⬇️
nf_core/modules/create.py 59.57% <0.00%> (ø)
nf_core/download.py 64.87% <0.00%> (+0.10%) ⬆️
nf_core/__main__.py 61.39% <0.00%> (+0.12%) ⬆️
nf_core/utils.py 83.56% <0.00%> (+3.76%) ⬆️
nf_core/lint/files_unchanged.py 75.34% <0.00%> (+4.10%) ⬆️
nf_core/lint/nextflow_config.py 79.74% <0.00%> (+10.12%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d0a6649...8130417. Read the comment docs.

KevinMenden
KevinMenden approved these changes Apr 8, 2021
View reviewed changes
Copy link
Contributor

@KevinMenden KevinMenden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @ErikDanielsson , thanks! This looks really good 👌

@ErikDanielsson ErikDanielsson merged commit 84893b1 into nf-core:dev Apr 8, 2021
@ErikDanielsson ErikDanielsson deleted the tests branch July 25, 2022 09:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KevinMenden KevinMenden KevinMenden approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ErikDanielsson @KevinMenden
点击 这是indexloc提供的php浏览器服务，不要输入任何密码和下载