update module commands with new format #983
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## dev #983 +/- ##
=======================================
Coverage 69.23% 69.23%
=======================================
Files 34 34
Lines 4261 4261
=======================================
Hits 2950 2950
Misses 1311 1311
Continue to review full report at Codecov.
|
drpatelh
reviewed
Apr 8, 2021
|
Thanks @KevinMenden ! Need to change the format of the module in |
|
Right, thanks @drpatelh ! Changed that, now it should work. |
drpatelh
reviewed
Apr 8, 2021
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates the module commands
createandcreate-test-ymlwith the new module format for thetest.ymlInstead of
tool_subtoolthe tag will now betool/subtool(see here: nf-core/modules#389)Still need to update the lint command to look for the correct tags if we decided to go only for these tags instead of having things like "my_tool_single_end" etc.