+
Skip to content

Make container/conda profiles more strict #866

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Mar 10, 2021
Merged

Make container/conda profiles more strict #866

merged 5 commits into from
Mar 10, 2021

Conversation

jfy133
Copy link
Member

@jfy133 jfy133 commented Feb 26, 2021

This draft PR is to act as a PoC for making container/conda profiles more strict as to what is being inherited.

Originally described on slack.

The purpose of the change is to ensure that, given nextflow inheritance rules, the final container/conda profile specified in -profile should be used. Currently conda is given a lower priority over containers, and if a container profile is specified somewhere in the profile list it will override the use of conda regardless if conda is specified last.

Use case: a user wants to run a pipeline using their institutional profile, where e.g. singularity is being used by default within the profile. However the user is test/developing a pipeline and would rather use conda.

PR checklist

  • This comment contains a description of changes (with reason)
  • CHANGELOG.md is updated
  • If you've fixed a bug or added code that should be tested, add tests!
  • Documentation in docs is updated

@jfy133 jfy133 marked this pull request as draft February 26, 2021 10:56
Copy link
Member

@ewels ewels left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't think of / remember any reason not to do this. So fine by me. 👍🏻

@maxulysse
Copy link
Member

Was doing that in Sarek, works well, I think I removed it with the lastest sync

@jfy133
Copy link
Member Author

jfy133 commented Feb 26, 2021

Should I post in the slack channel with a @channel ping to make sur eit's not going to break anything for anyone (maybe they have their own strategies, for whatever reason)? I feel this sort of a big change given everyone uses these profiles...

@maxulysse
Copy link
Member

or isn't it something that we would want to take care on within the configs? at an institutional level?

@jfy133
Copy link
Member Author

jfy133 commented Feb 26, 2021

I don't think so. The institutional example I gave is only one example, I think it could happen in other contexts with private configs, and the names of configs we are modifying here are most descriptive of the behaviour we are defining.

Unless I misunderstand?

@jfy133 jfy133 marked this pull request as ready for review March 6, 2021 19:37
@phue
Copy link
Member

phue commented Mar 8, 2021

I think this needs a rebase because of additional profiles that were introduced in bbd26ab

@ewels
Copy link
Member

ewels commented Mar 9, 2021

I think this needs a rebase because of additional profiles that were introduced in bbd26ab

Nice spot @phue 👌🏻 I pulled in the changes for you @jfy133 and pushed to your branch. If you could add in the other container engines as well then I think we're good to go.

@jfy133
Copy link
Member Author

jfy133 commented Mar 10, 2021

Done! Just to double check @phue - charliecloud does requires it's own 'dedicated' config (where the *.enabled option is defined)?

@jfy133 jfy133 requested a review from ewels March 10, 2021 08:07
@phue
Copy link
Member

phue commented Mar 10, 2021

It used to be required to set the container environment explicitly using an env block. That's what the additional config file was for. I opened #867 to get rid of this.
So either you pull the commits in here or I'll fix that up once this is merged 👍

@ewels ewels merged commit 7c3b828 into nf-core:dev Mar 10, 2021
ewels added a commit to ewels/nf-core-tools that referenced this pull request Mar 10, 2021
ewels added a commit that referenced this pull request Mar 10, 2021
@phue phue mentioned this pull request Mar 26, 2021
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants
点击 这是indexloc提供的php浏览器服务,不要输入任何密码和下载