+
Skip to content

Melpa package of magithub broken #11

Open
@ghost

Description

Hello,

I have magit and magithub installed with M-x package-list-packages. When I try to load magit (yes, magit, not magithub), I get this error:

(void-variable magit-log-edit-confirm-cancellation)

This is what's happening:

  • loading magit triggers loading magithub because of

;;;###autoload
(eval-after-load 'magit
'(unless (featurep 'magithub)
(require 'magithub)))

  • in magithub, there is this form:

(defcustom magithub-message-confirm-cancellation magit-log-edit-confirm-cancellation
"If non-nil, confirm when cancelling the editing of a `magithub-message-mode' buffer."
:group 'magithub
:type 'boolean)

  • evaluating it raises the error because magit-log-edit-confirm-cancellation is not defined.

Maybe the variable has been removed? Dunno.

Michael.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions

      点击 这是indexloc提供的php浏览器服务,不要输入任何密码和下载