feat(CommandPalette)!: add trailing-icon to the input and actions slot
#4397
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deployed ui3
|
commit: |
input-trailing-icon prop and slottrailing-icon to the input and actions slot
trailing-icon to the input and actions slottrailing-icon to the input and actions slot
benjamincanac
requested changes
Oct 10, 2025
| :name="trailingIcon || appConfig.ui.icons.chevronRight" | ||
| :class="ui.itemTrailingIcon({ class: [props.ui?.itemTrailingIcon, item.ui?.itemTrailingIcon] })" | ||
| :name="childrenIcon || appConfig.ui.icons.chevronRight" | ||
| :class="ui.childrenIcon({ class: [props.ui?.childrenIcon, item.ui?.childrenIcon] })" |
There was a problem hiding this comment.
Why not keep using ui.itemTrailingIcon here? 🤔
There was a problem hiding this comment.
Because in this case the icon only appears when the item has children, with itemTrailingIcon you'd think there'd be an icon for each item I think 🤔
| actions: '', | ||
| close: '', | ||
| back: 'p-0', | ||
| trailingIcon: 'shrink-0 size-5 text-dimmed', |
There was a problem hiding this comment.
This shouldn't be needed.
| itemLeadingChip: 'shrink-0 size-5', | ||
| itemLeadingChipSize: 'md', | ||
| itemTrailing: 'ms-auto inline-flex gap-1.5 items-center', | ||
| childrenIcon: 'shrink-0 size-5', |
There was a problem hiding this comment.
This shouldn't be needed.
|
|
||
| <template v-if="close || !!slots.close" #trailing> | ||
| <template v-if="trailingIcon || close || !!slots.close || !!slots.actions" #trailing> | ||
| <UIcon v-if="trailingIcon" :name="trailingIcon" :class="ui.trailingIcon({ class: props.ui?.trailingIcon })" /> |
There was a problem hiding this comment.
We should use the ui.trailingIcon from the UInput component here not from the CommandPalette. I'll make a PR to expose it (related to #4823)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔗 Linked issue
Resolves #3880
❓ Type of change
📚 Description