+
Skip to content

First working version #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
Jun 28, 2023
Merged

First working version #1

merged 10 commits into from
Jun 28, 2023

Conversation

MathisGD
Copy link
Contributor

@MathisGD MathisGD commented Jun 25, 2023 •
edited
Loading

First working version of Blue, with only one market but multiple LLTVs and no liquidation.

@MathisGD MathisGD self-assigned this Jun 25, 2023
@MathisGD MathisGD force-pushed the feat/first-working-version branch 3 times, most recently from 02e73ec to 1ccbffb Compare June 25, 2023 16:13
@MathisGD MathisGD force-pushed the feat/first-working-version branch from 1ccbffb to 76d30ff Compare June 25, 2023 16:15
@MathisGD MathisGD force-pushed the feat/first-working-version branch from 76d30ff to cec83d8 Compare June 25, 2023 16:17
QGarchery
QGarchery reviewed Jun 27, 2023
View reviewed changes
Copy link
Contributor

@QGarchery QGarchery left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very clean, I love it ! In particular it removes the need to set a specific tranche, and also the tests are much simpler and more efficient 👍

@MathisGD MathisGD mentioned this pull request Jun 27, 2023
Closed
@MathisGD MathisGD marked this pull request as ready for review June 27, 2023 22:04
@MathisGD MathisGD requested a review from QGarchery June 27, 2023 22:05
@QGarchery QGarchery changed the base branch from main to dev June 28, 2023 09:50
@MathisGD MathisGD merged commit 4b3e532 into dev Jun 28, 2023
@MathisGD MathisGD deleted the feat/first-working-version branch June 28, 2023 11:26
@MathisGD MathisGD mentioned this pull request Jun 28, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@QGarchery QGarchery QGarchery approved these changes

Assignees

@MathisGD MathisGD

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@MathisGD @QGarchery
点击 这是indexloc提供的php浏览器服务，不要输入任何密码和下载