+
Skip to content

Fixed test method for failing tests #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 5, 2024
Merged

Fixed test method for failing tests #4

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 14 additions & 15 deletions .github/workflows/test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,61 +10,58 @@ jobs:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4
- id: action-success-test
name: action-success-test
- name: action-success-test
uses: ./
with:
github_token: ${{ secrets.github_token }}
workdir: ./testdata
reporter: github-check
level: error
filter_mode: nofilter
fail_on_error: true
biome_flags: ok/
- id: action-failure-test
name: action-failure-test
# github-check test is judged to fail if an error occurs even if continue-on-error is set to true.
# Therefore, the test for failure should also succeed by setting the report level to warning.
- name: action-failure-test
uses: ./
continue-on-error: true
with:
github_token: ${{ secrets.github_token }}
workdir: ./testdata
reporter: github-check
level: warning
filter_mode: nofilter
fail_on_error: true
biome_flags: error/
- name: check-failure
if: steps.action-failure-test.outcome == 'success'
run: exit 1

test-pr-check:
if: github.event_name == 'pull_request'
name: runner / Biome (github-pr-check)
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4
- id: action-success-test
name: action-success-test
- name: action-success-test
uses: ./
with:
github_token: ${{ secrets.github_token }}
workdir: ./testdata
reporter: github-pr-check
level: error
filter_mode: nofilter
fail_on_error: true
biome_flags: ok/
- id: action-failure-test
name: action-failure-test
# github-pr-check test is judged to fail if an error occurs even if continue-on-error is set to true.
# Therefore, the test for failure should also succeed by setting the report level to warning.
- name: action-failure-test
uses: ./
continue-on-error: true
with:
github_token: ${{ secrets.github_token }}
workdir: ./testdata
reporter: github-pr-check
level: warning
filter_mode: nofilter
fail_on_error: true
biome_flags: error/
- name: check-failure
if: steps.action-failure-test.outcome == 'success'
run: exit 1

test-pr-review:
if: github.event_name == 'pull_request'
Expand All @@ -79,6 +76,7 @@ jobs:
github_token: ${{ secrets.github_token }}
workdir: ./testdata
reporter: github-pr-review
level: error
filter_mode: nofilter
fail_on_error: true
biome_flags: ok/
Expand All @@ -90,6 +88,7 @@ jobs:
github_token: ${{ secrets.github_token }}
workdir: ./testdata
reporter: github-pr-review
level: error
filter_mode: nofilter
fail_on_error: true
biome_flags: error/
Expand Down
点击 这是indexloc提供的php浏览器服务，不要输入任何密码和下载