Fix fog ledger router returning incorrect block number #3933
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nick-mobilecoin
commented
Feb 27, 2024
This was referenced Feb 27, 2024
sugargoat
reviewed
Apr 9, 2024
sugargoat
reviewed
Apr 9, 2024
sugargoat
reviewed
Apr 9, 2024
sugargoat
reviewed
Apr 9, 2024
sugargoat
reviewed
Apr 9, 2024
sugargoat
reviewed
Apr 9, 2024
sugargoat
reviewed
Apr 9, 2024
sugargoat
reviewed
Apr 10, 2024
sugargoat
reviewed
Apr 10, 2024
sugargoat
reviewed
Apr 10, 2024
sugargoat
reviewed
Apr 10, 2024
sugargoat
reviewed
Apr 10, 2024
sugargoat
approved these changes
Apr 10, 2024
sugargoat
reviewed
Apr 10, 2024
nick-mobilecoin
commented
Apr 11, 2024
Previously when a fog ledger store was spun up prior to the block chain having blocks in its block range it would return back 0 for the block number. This resulted in the collated response having 0 for the total number of blocks. Now stores will respond back with the range of blocks that they have processed and the collation logic will combine the overlapping ranges to come up with the highest available block count.
993f0ca to
1c282bf
Compare
|
|
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously when a fog ledger store was spun up prior to the block chain
having blocks in its block range it would return back 0 for the block
number. This resulted in the collated response having 0 for the total
number of blocks. Now stores will respond back with the range of
blocks that they have processed and the collation logic will combine the
overlapping ranges to come up with the highest available block count.