Parameterize TransactionBuilder for Token ID #2064
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cbeck88
reviewed
May 27, 2022
android-bindings/src/bindings.rs
Outdated
| // FIXME #1595: The token id should be a parameter and not hard coded to Mob | ||
| // here | ||
| let fee_amount = Amount::new(Mob::MINIMUM_FEE, Mob::ID); | ||
| let token_id = TokenId::try_from(token_id as u64).unwrap(); |
There was a problem hiding this comment.
i think this can just be TokenId::from, all u64's are potentially valid token ids
There was a problem hiding this comment.
Yeah, the problem is jlong ~= i64
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Parameterize TransactionBuilder Android bindings for token ID
Motivation
This is needed in order for the Android SDK to handle multiple different token IDs