fix a regression that prevented clients from re-attesting #2038
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcape
approved these changes
May 23, 2022
|
#2029 was opened earlier to try to add unit tests for this |
eranrund
added a commit
that referenced
this pull request
May 24, 2022
* fix a regression that prevented clients from re-attesting * rename method
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
A change introduced in #1592 results in clients not re-attesting. This happens because the code in https://github.com/mobilecoinfoundation/mobilecoin/blob/eran/async-reattest-bugfix/connection/src/traits.rs#L53 now only runs of if the async call (e.g.
client_tx_propose_async_opt) fails to queue a request. If it succeeds, then the actual result returned from the server would only get checked in https://github.com/mobilecoinfoundation/mobilecoin/blob/eran/async-reattest-bugfix/connection/src/thick.rs#L211 and currently that does not handle re-attestation.Future Work
Unit tests...