+
Skip to content

Remove bigint in favor of primitive-types. #1917

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 21 commits into from
May 19, 2022
Merged

Remove bigint in favor of primitive-types. #1917

merged 21 commits into from
May 19, 2022

Conversation

jcape
Copy link
Contributor

@jcape jcape commented May 3, 2022

Motivation

The bigint crate has not been maintained for a long time, we shouldn't use it.

In this PR

  • Update SCP crate to calculate weights and round hashes using primitive-types instead of bigint.

@jcape jcape added the dependencies Pull requests that update a dependency file label May 3, 2022
@jcape jcape self-assigned this May 3, 2022
@jcape jcape added this to the 1.2.0 Release milestone May 3, 2022
iamalwaysuncomfortable
iamalwaysuncomfortable approved these changes May 4, 2022
View reviewed changes
iamalwaysuncomfortable
iamalwaysuncomfortable approved these changes May 4, 2022
View reviewed changes
@jcape @iamalwaysuncomfortable
Update consensus/scp/src/slot.rs
61eb327 
Co-authored-by: Mike Turner <zaphrod.beeblebrox@gmail.com>
@jcape jcape marked this pull request as ready for review May 4, 2022 00:41
dependabot bot and others added 16 commits May 3, 2022 18:07
@dependabot
Bump serde from 1.0.136 to 1.0.137 in /fog/ledger/enclave/trusted (#1894
10537fa 
)

Bumps [serde](https://github.com/serde-rs/serde) from 1.0.136 to 1.0.137.
- [Release notes](https://github.com/serde-rs/serde/releases)
- [Commits](serde-rs/serde@v1.0.136...v1.0.137)

---
updated-dependencies:
- dependency-name: serde
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot
Bump serde from 1.0.136 to 1.0.137 in /fog/view/enclave/trusted (#1895)
8a86276 
Bumps [serde](https://github.com/serde-rs/serde) from 1.0.136 to 1.0.137.
- [Release notes](https://github.com/serde-rs/serde/releases)
- [Commits](serde-rs/serde@v1.0.136...v1.0.137)

---
updated-dependencies:
- dependency-name: serde
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot
Bump serde from 1.0.136 to 1.0.137 in /consensus/enclave/trusted (#1897)
8f9446d 
Bumps [serde](https://github.com/serde-rs/serde) from 1.0.136 to 1.0.137.
- [Release notes](https://github.com/serde-rs/serde/releases)
- [Commits](serde-rs/serde@v1.0.136...v1.0.137)

---
updated-dependencies:
- dependency-name: serde
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot
Bump serde from 1.0.136 to 1.0.137 in /fog/ingest/enclave/trusted (#1901
f7269be 
)

Bumps [serde](https://github.com/serde-rs/serde) from 1.0.136 to 1.0.137.
- [Release notes](https://github.com/serde-rs/serde/releases)
- [Commits](serde-rs/serde@v1.0.136...v1.0.137)

---
updated-dependencies:
- dependency-name: serde
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot
Bump serde from 1.0.136 to 1.0.137 (#1903)
5c998b2 
Bumps [serde](https://github.com/serde-rs/serde) from 1.0.136 to 1.0.137.
- [Release notes](https://github.com/serde-rs/serde/releases)
- [Commits](serde-rs/serde@v1.0.136...v1.0.137)

---
updated-dependencies:
- dependency-name: serde
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot
Bump semver from 1.0.7 to 1.0.9 (#1900)
9890373 
Bumps [semver](https://github.com/dtolnay/semver) from 1.0.7 to 1.0.9.
- [Release notes](https://github.com/dtolnay/semver/releases)
- [Commits](dtolnay/semver@1.0.7...1.0.9)

---
updated-dependencies:
- dependency-name: semver
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot
Bump zeroize from 1.5.4 to 1.5.5 in /fog/view/enclave/trusted (#1896)
ddbed60 
Bumps [zeroize](https://github.com/RustCrypto/utils) from 1.5.4 to 1.5.5.
- [Release notes](https://github.com/RustCrypto/utils/releases)
- [Commits](RustCrypto/utils@zeroize-v1.5.4...zeroize-v1.5.5)

---
updated-dependencies:
- dependency-name: zeroize
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot
Bump zeroize from 1.5.4 to 1.5.5 in /consensus/enclave/trusted (#1898)
9344404 
Bumps [zeroize](https://github.com/RustCrypto/utils) from 1.5.4 to 1.5.5.
- [Release notes](https://github.com/RustCrypto/utils/releases)
- [Commits](RustCrypto/utils@zeroize-v1.5.4...zeroize-v1.5.5)

---
updated-dependencies:
- dependency-name: zeroize
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot
Bump zeroize from 1.5.4 to 1.5.5 in /fog/ingest/enclave/trusted (#1899)
0b34e3b 
Bumps [zeroize](https://github.com/RustCrypto/utils) from 1.5.4 to 1.5.5.
- [Release notes](https://github.com/RustCrypto/utils/releases)
- [Commits](RustCrypto/utils@zeroize-v1.5.4...zeroize-v1.5.5)

---
updated-dependencies:
- dependency-name: zeroize
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Dependency updates (Part 1) (#1908)
2ceb8eb 
* Update regex in consensus enclave to 1.5.5

* Update crossbeam utils 0.8.5 to 0.8.8

* Update generic-array 0.12.3 to 0.12.4

* Update hyper from 0.12.35 to 0.12.36

* Update hyper 0.14.16 to 0.14.18

* Ran cargo update against protoc, somehow log is back to the right version.

* Update log to 0.4.17.

* Fix protoc again...
@eranrund
Switch to using our fork of opentelemetry. (#1918)
3fdec39 
This was needed since we had to upgrade opentelemetry-jaeger's
dependency on thrift, which in turn depended on a broken verison of
ordered-float.
@eranrund
Upgrade to rocket 0.5.0-rc (#1913)
0410941 
* mobilecoind-json uses new(er) rocket

* admin gw uses newer rocket

* fog-overseer-server uses newer rocket
blah.
f67ef5e
Unblah.
d26bfbe
Merge branch 'master' into hotfix/scp-bigint
729b246
hat.
14d1412
remoun
remoun approved these changes May 4, 2022
View reviewed changes
@jcape jcape merged commit 733ee19 into mobilecoinfoundation:master May 19, 2022
jcape pushed a commit that referenced this pull request May 19, 2022
@dependabot @awygle @eranrund
Cherry-pick updates from master. (#2006)
afdf66c 
* Bump ed25519 from 1.5.0 to 1.5.2 (#1987)

Bumps [ed25519](https://github.com/RustCrypto/signatures) from 1.5.0 to 1.5.2.
- [Release notes](https://github.com/RustCrypto/signatures/releases)
- [Commits](RustCrypto/signatures@ed25519/v1.5.0...ed25519/v1.5.2)

---
updated-dependencies:
- dependency-name: ed25519
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Bump rayon from 1.5.2 to 1.5.3 (#1985)

Bumps [rayon](https://github.com/rayon-rs/rayon) from 1.5.2 to 1.5.3.
- [Release notes](https://github.com/rayon-rs/rayon/releases)
- [Changelog](https://github.com/rayon-rs/rayon/blob/master/RELEASES.md)
- [Commits](rayon-rs/rayon@v1.5.2...v1.5.3)

---
updated-dependencies:
- dependency-name: rayon
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Bump rocket from 0.5.0-rc.1 to 0.5.0-rc.2 (#1949)

* Bump rocket from 0.5.0-rc.1 to 0.5.0-rc.2

Bumps [rocket](https://github.com/SergioBenitez/Rocket) from 0.5.0-rc.1 to 0.5.0-rc.2.
- [Release notes](https://github.com/SergioBenitez/Rocket/releases)
- [Changelog](https://github.com/SergioBenitez/Rocket/blob/master/CHANGELOG.md)
- [Commits](rwf2/Rocket@v0.5.0-rc.1...v0.5.0-rc.2)

---
updated-dependencies:
- dependency-name: rocket
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>

* Update for Rocket v0.5.0-rc.2

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Andrew Wygle <andrew@mobilecoin.com>

* Bump ed25519 from 1.5.0 to 1.5.2 in /fog/view/enclave/trusted (#1983)

Bumps [ed25519](https://github.com/RustCrypto/signatures) from 1.5.0 to 1.5.2.
- [Release notes](https://github.com/RustCrypto/signatures/releases)
- [Commits](RustCrypto/signatures@ed25519/v1.5.0...ed25519/v1.5.2)

---
updated-dependencies:
- dependency-name: ed25519
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Bump ed25519 from 1.5.0 to 1.5.2 in /consensus/enclave/trusted (#1982)

Bumps [ed25519](https://github.com/RustCrypto/signatures) from 1.5.0 to 1.5.2.
- [Release notes](https://github.com/RustCrypto/signatures/releases)
- [Commits](RustCrypto/signatures@ed25519/v1.5.0...ed25519/v1.5.2)

---
updated-dependencies:
- dependency-name: ed25519
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Implement some improvements to the `mc-consensus-mint-client` utility (#1993)

* add TxFile and dump subcommand

* add signing command

* Uprev mbedtls to the newer version. (#2002)

* Remove bigint in favor of primitive-types. (#1917)

* Replace bigint with primitive_types.
* rustfmt like a n00b
* Update consensus/scp/src/slot.rs
* Sort SCP dependencies.

* Import std::convert::TryFrom

* Fix build (again).

* pr review fixes (#2000)

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Andrew Wygle <andrew@mobilecoin.com>
Co-authored-by: Eran Rundstein <eran@rundste.in>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@eranrund eranrund eranrund approved these changes

+2 more reviewers

@remoun remoun remoun approved these changes

@iamalwaysuncomfortable iamalwaysuncomfortable iamalwaysuncomfortable approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@jcape jcape

Labels

dependencies Pull requests that update a dependency file

Projects

Blockchain Core
Archived in project

Milestone

v2.0.0

Development

Successfully merging this pull request may close these issues.

4 participants

@jcape @remoun @eranrund @iamalwaysuncomfortable
点击 这是indexloc提供的php浏览器服务，不要输入任何密码和下载