+
Skip to content

Generate tonic protos for api crates #4064

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: release/v7.1
Choose a base branch
from
Open

Generate tonic protos for api crates #4064

wants to merge 1 commit into from

Conversation

nick-mobilecoin
Copy link
Collaborator

No description provided.

nick-mobilecoin
nick-mobilecoin commented Sep 18, 2025
View reviewed changes
Cargo.toml
Comment on lines +345 to +346
tonic = { version = "0.9", default-features = false }
tonic-build = "0.9"
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Version 0.9 is the one that works with prost 0.11

nick-mobilecoin
nick-mobilecoin commented Sep 18, 2025
View reviewed changes
api/src/lib.rs
include!(concat!(env!("OUT_DIR"), "/protos-auto-gen/mod.rs"));
}

pub mod tonic {
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I figure push these into a tonic namespace to avoid conflicting with the pub use crate::{autogenerated_code::* below

nick-mobilecoin
nick-mobilecoin commented Sep 18, 2025
View reviewed changes
t3/api/src/lib.rs
Comment on lines +18 to +21
pub mod tonic {
pub mod external {
pub mod v1 {
tonic::include_proto!("external.v1");
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not sure on this nesting here, may need to wait until the actual tonic implementations of gRPC is done

@github-actions GitHub Actions
Copy link

⚠️ Downstream repo mobilecoinofficial/full-service failed to build. Check actions status for details.

@github-actions GitHub Actions
Copy link

⚠️ Downstream repo mobilecoinofficial/android-bindings failed to build. Check actions status for details.

@github-actions GitHub Actions
Copy link

⚠️ Downstream repo mobilecoinofficial/android-bindings failed to build. Check actions status for details.

@github-actions GitHub Actions
Copy link

⚠️ Downstream repo mobilecoinofficial/full-service failed to build. Check actions status for details.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@eranrund eranrund eranrund approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@nick-mobilecoin @eranrund
点击 这是indexloc提供的php浏览器服务，不要输入任何密码和下载