+
Skip to content

Can't pass additional arguments via more.args to simple filter #2709

@annette987

Description

@annette987

After recent changes to filters (#2693) it is no longer possible to pass additional arguments to a simple filter via more.args:

library(survival)
library(mlr)
#> Loading required package: ParamHelpers
#> 'mlr' is in maintenance mode since July 2019. Future development
#> efforts will go into its successor 'mlr3' (<https://mlr3.mlr-org.com>).

set.seed(24601)
data(veteran)
mas.task <- makeSurvTask(id = "VET", data = veteran, target = c("time", "status"))
outer = makeResampleDesc("CV", iters = 2, stratify = TRUE)

cox.filt.mindepth.lrn = makeFilterWrapper(
    makeLearner(cl = "surv.coxph", id = "cox.filt.mindepth", predict.type = "response"), 
    fw.method = "randomForestSRC_var.select",
    fw.abs = 5,
    more.args = list("metho" = "md", ntree=100, nsplit = 10, nodesize = 3)
  )

learners = list(cox.filt.mindepth.lrn)   
bmr = benchmark(learners, mas.task, outer, show.info = TRUE)
#> Task: VET, Learner: cox.filt.mindepth.filtered
#> Resampling: cross-validation
#> Measures:             cindex
#> Error in generate.fv.data(task = task, method = method, nselect = getTaskNFeats(task), : Assertion on 'more.args' failed: Must have length <= 1, but has length 4.

Created on 2020-01-08 by the reprex package (v0.3.0)

I can submit a PR to fix this.

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions

      点击 这是indexloc提供的php浏览器服务,不要输入任何密码和下载