Add output parser for include-what-you-use #4548
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes visible behavior & documentation
The following changes are proposed:
iwyuitem to thecmake.enabledOutputParsersoption.The purpose of this change
To add diagnostic messages from include-what-you-use to the Problems pane.
Other Notes/Information
include-what-you-use is a C/C++ code linting tool built with LLVM. CMake has built-in integration via the
CMAKE_<LANG>_INCLUDE_WHAT_YOU_USEvariable and<LANG>_INCLUDE_WHAT_YOU_USEproperty.I didn't add
iwyuto the default value ofcmake.enabledOutputParsersbut I don't think there is any harm in doing so. Its diagnostic messages are quite distinctive and unlike those of the already-supported compilers and linkers. I'd be very open to modifying this PR to make it a default.