Added Open With apps for macOS #917
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5f2d06c to
02692f4
Compare
|
PR updated with Preference settings - ready for a review |
|
PR updated - reverted changes to Preferences and using menu to show a hint how to enable apps in Open With. |
36bf808 to
78a281a
Compare
|
PR rebased |
ahadas
reviewed
May 13, 2023
mucommander-command/src/main/java/com/mucommander/command/CommandManager.java
Outdated
Show resolved
Hide resolved
mucommander-command/src/main/java/com/mucommander/command/CommandManager.java
Outdated
Show resolved
Hide resolved
mucommander-core/src/main/java/com/mucommander/core/desktop/DesktopManager.java
Outdated
Show resolved
Hide resolved
mucommander-core/src/main/java/com/mucommander/ui/main/menu/TablePopupMenu.java
Outdated
Show resolved
Hide resolved
mucommander-core/src/main/java/com/mucommander/ui/main/menu/OpenWithMenu.java
Outdated
Show resolved
Hide resolved
mucommander-core/src/main/java/com/mucommander/ui/main/menu/OpenWithMenu.java
Show resolved
Hide resolved
mucommander-command/src/main/java/com/mucommander/command/CommandExtended.java
Outdated
Show resolved
Hide resolved
mucommander-command/src/main/java/com/mucommander/command/CommandManager.java
Outdated
Show resolved
Hide resolved
mucommander-command/src/main/java/com/mucommander/command/CommandManager.java
Outdated
Show resolved
Hide resolved
And whether the "right way way" from #759 (comment) is still OK when it comes to Apple M1 (brew installs under a different folder in M1s). |
|
PR updated addressing comments that I've marked as 'resolved' |
|
PR updated (CommandExtended moved to Command) |
ahadas
reviewed
May 14, 2023
mucommander-core/src/main/java/com/mucommander/ui/main/menu/OpenWithMenu.java
Outdated
Show resolved
Hide resolved
mucommander-os-macos/src/main/java/com/mucommander/desktop/macos/OSXDesktopAdapter.java
Outdated
Show resolved
Hide resolved
mucommander-os-macos/src/main/java/com/mucommander/desktop/macos/OSXDesktopAdapter.java
Outdated
Show resolved
Hide resolved
mucommander-os-macos/src/main/java/com/mucommander/desktop/macos/OSXDesktopAdapter.java
Show resolved
Hide resolved
|
PR updated addressing review comments |
ahadas
approved these changes
May 15, 2023
|
thanks @pskowronek ! |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added Open With apps for macOS, #759
The change only adds apps to Open With under macOS and only for contextual (right click) menu - Main menu is left as it was (not sure if we want apps to be added to it and if so how/when to refresh the Open With menu in there).
Since finding apps for a given file can take a while for extension with a lot of apps, I added 'Loading...' to menu and moved the process to background. The delay is mostly from
mdfindthat gets app name from bundle id.Information how to enable this feature on macOS: