+
Skip to content

Dagger (#31) #32

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 22, 2018
Merged

Dagger (#31) #32

merged 1 commit into from
Feb 22, 2018

Conversation

alvarez-fabian
Copy link
Contributor

Dagger release

  • Add Log wrapper to mock instances when doing tests
  • Update WolmoFragmentHandler to inject and use the new Logger
  • Bump sdk version and appcompat version
  • Extract method from ImageProvider and add unit tests for it
  • Remove powermock dependency and add Robolectric
  • Remove powermock dependency and update test that used it to use Robolectric.
  • Add missing javadoc and fix some typos.
  • Fix some issues with Providers and update tests to test the changes.
  • Add missing tests

Dagger release

* Add Log wrapper to mock instances when doing tests
* Update WolmoFragmentHandler to inject and use the new Logger
* Bump sdk version and appcompat version
* Extract method from ImageProvider and add unit tests for it
* Remove powermock dependency and add Robolectric
* Remove powermock dependency and update test that used it to use Robolectric.
* Add missing javadoc and fix some typos.
* Fix some issues with Providers and update tests to test the changes.
* Add missing tests
@alvarez-fabian alvarez-fabian changed the title Dagger rc2 (#31) Dagger (#31) Feb 22, 2018
Copy link
Contributor

@Karamchi Karamchi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@alvarez-fabian alvarez-fabian merged commit 25d4881 into master Feb 22, 2018
@coveralls
Copy link

Coverage Status

Coverage increased (+71.7%) to 90.811% when pulling 243c7ce on development into 9ce2bae on master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants
点击 这是indexloc提供的php浏览器服务,不要输入任何密码和下载