Fix a crash when no presenter is used in a fragment #34
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Update build tools version * Change WolmoFragmentHandler and DefaultModule to support no presenter o base presenter * Remove unused reflection code * Remove unused tests
SpicyCactuar
suggested changes
Apr 3, 2018
| @@ -120,24 +124,9 @@ View onCreateView(LayoutInflater inflater, @Nullable ViewGroup container, | |||
| @SuppressWarnings("unchecked") | |||
| void onViewCreated(View view, @Nullable Bundle savedInstanceState) { | |||
There was a problem hiding this comment.
Add the @NonNull to the View view parameter. It was added in one of the latest Android API updates. It's nice because, if this method is called, the Fragment has to have a View.
| * @since 2014-04-13 | ||
| */ | ||
| @RestrictTo(RestrictTo.Scope.LIBRARY) | ||
| public class ReflectionUtils { |
| @Inject T mPresenter; | ||
| @Inject ToastFactory mToastFactory; | ||
| @Inject Logger mLogger; | ||
| private @Nullable T mPresenter; |
There was a problem hiding this comment.
I like this but we should add a requirePresenter() method that returns a Presenter, if it's not null, or throws an NPE if it isn't. This method should return a @NonNull Presenter which is nice for both Java and Kotlin.
|
I tried to update gradle, but butterknife explodes. So for now it's better to keep gradle outdated. 😞 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary