Various improvements to performance and the API #4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Serialize bloom bitmap to an Erlang binary, not a list * Add new_for_fp_rate/2 and check_and_set/2 * Make return types more idiomatic * Make clear/1 clear the current bloom, don't copy it * Add documentation and type specs * Remove redundant information from the resource struct * Add deserialization helper for deserializing the tuple returned from serialize
ba09c08 to
1ed5f0b
Compare
|
I have some more stuff coming (stemming from trying to use the bloom for what I need it to) which includes being able to check/set any Erlang term and being able to quickly check a serialized bloom for key membership without having to deserialize it fully. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes are backwards incompatible so, if merged, this would probably require a bump to version 2.0 if semantic versioning is being used.